[LUA/SQL] Add Floral Bouquet mobskill #5747
Draft
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UmeboshiXI
reviewed
May 31, 2024
| @@ -2179,7 +2179,7 @@ INSERT INTO `mob_skills` VALUES (2162,1571,'emetic_discharge',0,7.0,2000,1000,4, | |||
| INSERT INTO `mob_skills` VALUES (2163,1549,'seedspray',0,11.5,2000,1500,4,0,0,0,0,0,0); | |||
| INSERT INTO `mob_skills` VALUES (2164,1550,'viscid_emission',4,10.0,2000,1500,4,0,0,0,0,0,0); | |||
| -- INSERT INTO `mob_skills` VALUES (2165,1551,'rotten_stench',0,7.0,2000,1500,4,0,0,0,0,0,0); | |||
| -- INSERT INTO `mob_skills` VALUES (2166,1552,'floral_bouquet',0,7.0,2000,1500,4,0,0,0,0,0,0); | |||
| INSERT INTO `mob_skills` VALUES (2166,1552,'floral_bouquet',1,10.0,2000,1500,2048,8,0,0,0,0,0); | |||
There was a problem hiding this comment.
Just added this and Mowford's target type PR on my local to test it out.
- Floral Bouquet will need its mob_valid_targets set to 2052 if combined with Mow's PR. (Mob wouldn't use it otherwise for me)
UmeboshiXI
reviewed
May 31, 2024
|
|
||
| mobskillObject.onMobWeaponSkill = function(target, mob, skill) | ||
| if target:isMob() and not target:isPet() then | ||
| if target:getFamily() == 48 then |
There was a problem hiding this comment.
When we were discussing on how to implement Floral Bouquet on discord, we found from caps that this skill seems to affect more than just Bees. It seems to charm all Vermin(Crawlers, Flies etc) so could probably update this to use target:getEcosystem() == xi.ecosystem.VERMIN .
UmeboshiXI
pushed a commit
to CactuarXI/server
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Adds Rafflesia's Floral Bouquet mobskill. Requires implementing the ability to target both players and mobs (to be done in #5745). Resolves an item in #202
https://docs.google.com/spreadsheets/d/1YBoveP-weMdidrirY-vPDzHyxbEI2ryECINlfCnFkLI/edit#gid=57955395
https://www.bg-wiki.com/ffxi/Category:Rafflesia
https://wiki.ffo.jp/html/24577.html
https://www.youtube.com/watch?v=pHlyddUe_xg
https://www.youtube.com/watch?v=e667RCOl958
https://www.youtube.com/watch?v=iwaoNhI06TI
https://www.youtube.com/watch?v=TZ9H8lp6hC0
https://www.youtube.com/watch?v=26rqrnRd5e0
https://www.youtube.com/watch?v=VrxYRqnNx4E
https://www.youtube.com/watch?v=zTgf4u-eE_s
https://www.youtube.com/watch?v=HrhrMm9NfUA
https://www.youtube.com/watch?v=GBqwcvOnWeY
Steps to test these changes