[Cleanup] Shift-proof "B" Zones

[Frankie-hz]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Shift proof
Bubu Pennisula
Bostaunieux Oubliette
Bhaflau Thickets
Behemoths Dominion
Beaucedine Glacier & [S]
Bearclaw
Beadeaux [S]
Beadeaux
Batallia Downs [S]
Batallia Downs
Bastok mines
Bastok Markets [S]

Steps to test these changes

Lotto NMs/start server see no lookup errors

[ampitere]

Would something like GetTableOfIDs('Bloodsucker')[X], be better?

[Frankie-hz]

Ah thank you, I meant to put it as a question completely skipped my mind. I wasn’t sure if we wanted a tableid[] or not because there are 15 bloodsuckers I think (on phone cant look).I was brainstorming to see if I could come up with something else that made more sense but I think thats the best idea.

[Frankie-hz]

Updated to [42]. I wish we had an easier way of doing this, it just looks/feels really odd

[ampitere]

Would be nice if we had something like GetFirstNMId() but I don't think there's any way to differentiate the records at the moment.

[claywar]

Nope, its just one dumb list (well, two dumb lists that should be one, but that's a story for another day between NPCs and Mobs)

[claywar]

CI is definitely not liking something here with the changes, not sure what's going on from the logs yet, but there's definitely an issue vs other branches

[Frankie-hz]

I can't seem to narrow is down

[WinterSolstice8]

Will take a look

[WinterSolstice8]

Running locally it's fine. hmm...

[WinterSolstice8]

I've asked frank to add a commit to allow the workflow to print the exception I suspect it is throwing in Python:

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9e37fdf6fe..f2a39fce2e 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -509,6 +509,7 @@ jobs:
               hxi_client.logout()
               exit(0)
           except Exception as e:
+              print(e)
               exit(-1)
           EOF
           hxi_result=$?

[WinterSolstice8]

Well of course it worked now, thanks github