Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GM command for banning or unbanning players from using /YELL #5729

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

CatsEyeXI
Copy link

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds a GM command that allows for banning or unbanning of a player's yell privileges.

Steps to test these changes

image

@CatsEyeXI CatsEyeXI force-pushed the yell_bans branch 2 times, most recently from 5222ff2 to fb5c434 Compare May 16, 2024 00:46
@CatsEyeXI
Copy link
Author

sorry for the multiple force pushes, had an issue deciding what the command trigger should actually be.

@MowFord
Copy link
Contributor

MowFord commented May 17, 2024

Btw a rebase will resolve your ci failure

@CatsEyeXI
Copy link
Author

Maintainers: I'm not in any rush for you guys to merge this or anything, just wondering if you need anything from me, or if it's undesired. Either way completely fine, I just have some OCD about leaving stale branches out there. 🫶

Copy link
Member

@WinterSolstice8 WinterSolstice8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github seems to have removed my ability to restart CI on this PR so you might have to rebase and force push to get it to try again.

@CatsEyeXI
Copy link
Author

Github seems to have removed my ability to restart CI on this PR so you might have to rebase and force push to get it to try again.

all set, mister.

@zach2good zach2good merged commit f75f197 into LandSandBoat:base Jul 16, 2024
11 checks passed
@CatsEyeXI CatsEyeXI deleted the yell_bans branch July 20, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants