Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMK, Lua] Mission 13 puzzle 2 - Xarcabard Trivia implemented #5058

Merged

Conversation

Flibe-XI
Copy link
Contributor

@Flibe-XI Flibe-XI commented Feb 2, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Implements puzzle two of AMK mission 13, trivia challenge in Xarcabard. This one uses a complex system of CS args to convey correct/incorrect answers and npc ids into the cutscene to have the event run properly. To confuse things, there are two sets of indices for labeling the three stooge npcs, one starting at 0 and one starting at 1. Both are required and used separately to determine different things in the event. 0-indexed val refers to which Option npc to point to for correct/wrong answers, and 1-indexed stoogeNum tells cutscene which stooge moogle location to animate.

Steps to test these changes

!addmission 10 12
Beat the first puzzle in beauc, head to an Option npc in xarc
Answer the trivia questions, right and wrong.
Right - Should recieve Guantlet Challenge Kupon after three right answers
Wrong - Have to start the trivia questions over, no need to zone

By the way, huge shout out to player Raguza for posting excellent captures to FFXI Captures discord (for all of AMK!). Couldn't have done this without those.

Almost all logic for determining cutscenes is handled by event arguments
I've done my best to make all the arguments self-explanatory via their names
@Flibe-XI Flibe-XI force-pushed the mission_13_puz_2 branch 4 times, most recently from 985a4cd to 6c4f9a9 Compare February 2, 2024 05:13
Also condensed functions for beauc puzzle into helpers.lua
Copy link
Contributor

@zach2good zach2good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, huge shout out to player Raguza for posting excellent captures to FFXI Captures discord (for all of AMK!). Couldn't have done this without those.

image

@Flibe-XI
Copy link
Contributor Author

Flibe-XI commented Feb 2, 2024

By the way, huge shout out to player Raguza for posting excellent captures to FFXI Captures discord (for all of AMK!). Couldn't have done this without those.

Haha I didn't realize that was you. Well then, thanks to Zach!

@zach2good zach2good merged commit eeaf96b into LandSandBoat:feature/amk_missions Feb 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants