[AMK, Lua, SQL] Mission 9, stone hunt in quicksands caves complete #4850

Flibe-XI · 2023-12-11T04:07:44Z

I affirm:

I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
I have read and understood the Contributing Guide and the Code of Conduct.
I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Implementation of Rescue! A Moogles Labor of Love, mission 9 of AMK. The player needs to collect 9 'stone' key items by clicking various question marks in quicksands caves. There are 20 possible QMs, and 10 possible sets of combinations required to check. The set which is assigned randomly in this commit is then passed as an arg to the geologist event which marks the map.

Steps to test these changes

!addmission 10 8
!pos -737 -6 -550 208
Talk to goblin geologist, he will assign a marker set to you. Go around quicksands and click the markers shown on the map for your stone KIs. (alternatively, !gotoid ###, ids are in the mission lua file)
Return to goblin to get KI Navaratna Talisman.
Get CS at shimmering circle in chamber of oracles.

scripts/missions/amk/09_Rescue_A_Moogles_Labor_of_Love.lua

zach2good

Getting closer, thanks for all the hard work 🖖 (there's no regular salute emoji?)

zach2good · 2023-12-12T09:32:07Z

scripts/zones/Quicksand_Caves/IDs.lua

@@ -117,6 +120,26 @@ zones[xi.zone.QUICKSAND_CAVES] =
        CHAINS_THAT_BIND_US_QM = 17629746,
        TREASURE_COFFER        = 17629747,
        ANTICAN_TAG_QM         = 17629769,
+        QM_AMK_1               = 17629668,


These are still raw IDs, you need to be using GetFirstID or GetTableOfIDs to pull these from the db at load time - which makes them more shift-proof

That is really cool. Had to rejig the markerSets table in the mission lua. Did it via find/replace and spot checked it. Works great!

zach2good · 2023-12-12T09:32:39Z

scripts/zones/Quicksand_Caves/IDs.lua

@@ -40,6 +41,7 @@ zones[xi.zone.QUICKSAND_CAVES] =
        HOMEPOINT_SET                 = 11435, -- Home point set!
        UNITY_WANTED_BATTLE_INTERACT  = 11493, -- Those who have accepted % must pay # Unity accolades to participate. The content for this Wanted battle is #. [Ready to begin?/You do not have the appropriate object set, so your rewards will be limited.]
    },
+


No need for these additional linebreaks, none of the other ID files have them

Oh, I had found one that did, so I thought that was the default.

See Qufim Island, the only one near it like that haha. Bad luck.

zach2good · 2023-12-12T09:34:23Z

scripts/zones/Quicksand_Caves/DefaultActions.lua

@@ -1,6 +1,7 @@
 local ID = zones[xi.zone.QUICKSAND_CAVES]

 return {
+    ['qmAMK']             = { messageSpecial = ID.text.NOTHING_OUT_OF_ORDINARY },


Looking at all the other qm's we have in the codebase, they're all in snake_case, can you make this match? qm_amk, etc.

scripts/missions/amk/09_Rescue_A_Moogles_Labor_of_Love.lua

sql/npc_list.sql

zach2good · 2023-12-12T09:38:03Z

scripts/zones/Quicksand_Caves/npcs/amk_qm.lua

@@ -0,0 +1,12 @@
+-----------------------------------
+-- Area: Quicksand Caves
+-- NPC: qm (???)


Name doesn't match the filename

zach2good · 2023-12-12T09:38:33Z

scripts/zones/Quicksand_Caves/npcs/amk_qm.lua

@@ -0,0 +1,12 @@
+-----------------------------------


This is the correct naming for file here, can you update npc_list and the mission script to key on this?

zach2good · 2023-12-12T09:39:09Z

scripts/zones/Quicksand_Caves/npcs/amk_qm.lua

+-----------------------------------
+-- Area: Quicksand Caves
+-- NPC: qm (???)
+-- Mission: AMK - Rescue! A Moogle's Labor of Love


Probably worth adding a comment saying this script is shared between all the AMK qm's for this mission, to avoid confusion or someone bloating out the zone with multiple empty files - one for each qm

zach2good · 2023-12-12T09:40:23Z

I skipped over implementing this mission on my branch way-back-when, because it looked like a pain in the ass, thanks for getting to it 👍

Flibe-XI · 2023-12-12T14:40:12Z

I skipped over implementing this mission on my branch way-back-when, because it looked like a pain in the ass, thanks for getting to it 👍

That seems to be the theme SE was going for with AMK missions. This one was just tedious but the puzzles were even worse.

zach2good · 2023-12-16T10:55:09Z

scripts/zones/Quicksand_Caves/IDs.lua

@@ -117,6 +118,7 @@ zones[xi.zone.QUICKSAND_CAVES] =
        CHAINS_THAT_BIND_US_QM = 17629746,
        TREASURE_COFFER        = 17629747,
        ANTICAN_TAG_QM         = 17629769,
+        QM_AMK                 = GetTableOfIDs('qm_amk')


Flibe-XI changed the title ~~[AMK, Lua, sql] Mission 9, stone hunt in quicksands caves complete~~ [AMK, Lua, SQL] Mission 9, stone hunt in quicksands caves complete Dec 11, 2023

Flibe-XI force-pushed the rescue-talisman-hunt branch 3 times, most recently from b9a2b8a to aadb641 Compare December 11, 2023 04:22

Xaver-DaRed reviewed Dec 11, 2023

View reviewed changes

scripts/missions/amk/09_Rescue_A_Moogles_Labor_of_Love.lua Outdated Show resolved Hide resolved

Flibe-XI force-pushed the rescue-talisman-hunt branch from aadb641 to 241f2ef Compare December 12, 2023 00:57

zach2good requested changes Dec 12, 2023

View reviewed changes

Flibe-XI force-pushed the rescue-talisman-hunt branch 2 times, most recently from 2ffd6a7 to 555ac46 Compare December 13, 2023 03:17

mission 9 complete

89bbfb8

Flibe-XI force-pushed the rescue-talisman-hunt branch from 555ac46 to 89bbfb8 Compare December 13, 2023 03:39

zach2good approved these changes Dec 16, 2023

View reviewed changes

zach2good merged commit cd7630b into LandSandBoat:feature/amk_missions Dec 16, 2023
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AMK, Lua, SQL] Mission 9, stone hunt in quicksands caves complete #4850

[AMK, Lua, SQL] Mission 9, stone hunt in quicksands caves complete #4850

Flibe-XI commented Dec 11, 2023

zach2good left a comment

zach2good Dec 12, 2023

Flibe-XI Dec 13, 2023 •

edited

Loading

zach2good Dec 12, 2023

Flibe-XI Dec 12, 2023

Flibe-XI Dec 13, 2023

zach2good Dec 12, 2023

zach2good Dec 12, 2023

zach2good Dec 12, 2023

zach2good Dec 12, 2023

zach2good commented Dec 12, 2023

Flibe-XI commented Dec 12, 2023

zach2good Dec 16, 2023

[AMK, Lua, SQL] Mission 9, stone hunt in quicksands caves complete #4850

[AMK, Lua, SQL] Mission 9, stone hunt in quicksands caves complete #4850

Conversation

Flibe-XI commented Dec 11, 2023

What does this pull request do?

Steps to test these changes

zach2good left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Flibe-XI Dec 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zach2good commented Dec 12, 2023

Flibe-XI commented Dec 12, 2023

Choose a reason for hiding this comment

Flibe-XI Dec 13, 2023 •

edited

Loading