Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMK][Lua] Added check and reminder text to AMK 6, enabled repeatability #4787

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

Flibe-XI
Copy link
Contributor

@Flibe-XI Flibe-XI commented Dec 1, 2023

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • added check to make sure player has at least one orb (cardian flavor orbs) before initiating cardian fight in amk mission 6
  • added flavor text when on the mission but player has no orbs
  • enabled ability to repeat the mission after completing it
  • found an off-by-one error in the zone text ids

Steps to test these changes

!addmission 10 5
!gotoid 17572302
Touch QM, it should tell player that an orb could cause something to happen
!addkeyitem orb_of_swords
Touch QM again, it should start the fight prompt
!addmission 10 6
Touch QM again, it should still start the fight prompt if player has an orb and doesn't have the ripe_starfruit KI

@zach2good
Copy link
Contributor

Just how repeatable is this? What are the mechanics for these key items dropping from local Cardians? Are the cardians ALWAYS meant to drop these items and you can come back later if you've bought them again from Squintox? Or are the drop mechanics for these KIs not implemented yet?

@zach2good
Copy link
Contributor

These two should land at the same time: #4800

@zach2good zach2good merged commit 10f79a1 into LandSandBoat:feature/amk_missions Dec 3, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants