[core] Fix conquest logs / latent effects not applying when zoning into non conquest areas #4624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
Please enter a player-facing description
Fix latent effects from conquest related items not triggering when zoning into new areas.
Fix latent effects from conquest related items not triggering in zones that are not part of conquest, but should otherwise trigger these effects (I,e sky / sea)
What does this pull request do? (Please be technical)
Steps to test these changes
Zone into a sea with items such as master caster bracelets. Check that latent applies and there are no errors logged about "Invalid conquest region passed to function"
Special Deployment Considerations
I (@xkoredev) have smoke tested this. I am cherry picking from ASB, but I affirm:
Please enter a player-facing description
Fix latent effects from conquest related items not triggering when zoning into new areas.
Fix latent effects from conquest related items not triggering in zones that are not part of conquest, but should otherwise trigger these effects (I,e sky / sea)
What does this pull request do? (Please be technical)
Steps to test these changes
Zone into a sea with items such as master caster bracelets. Check that latent applies and there are no errors logged about "Invalid conquest region passed to function"
Special Deployment Considerations
I (@xkoredev) have smoke tested this. I am cherry picking from ASB, but @Radegast-FFXIV will properly test this and answer any questions.