Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix conquest logs / latent effects not applying when zoning into non conquest areas #4622

Closed

Conversation

xkoredev
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

Please enter a player-facing description

Fix latent effects from conquest related items not triggering when zoning into new areas.
Fix latent effects from conquest related items not triggering in zones that are not part of conquest, but should otherwise trigger these effects (I,e sky / sea)

What does this pull request do? (Please be technical)

Steps to test these changes

Zone into a sea with items such as master caster bracelets. Check that latent applies and there are no errors logged about "Invalid conquest region passed to function"

Special Deployment Considerations

I (@xkoredev) have smoke tested this. I am cherry picking from ASB, but I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

Please enter a player-facing description

Fix latent effects from conquest related items not triggering when zoning into new areas.
Fix latent effects from conquest related items not triggering in zones that are not part of conquest, but should otherwise trigger these effects (I,e sky / sea)

What does this pull request do? (Please be technical)

Steps to test these changes

Zone into a sea with items such as master caster bracelets. Check that latent applies and there are no errors logged about "Invalid conquest region passed to function"

Special Deployment Considerations

I (@xkoredev) have smoke tested this. I am cherry picking from ASB, but @Radegast-FFXIV will properly test this and answer any questions.

@xkoredev xkoredev changed the title [core] Fix nation zone/login issues. [core] Fix latent effects not applying when zoning into non conquest areas Oct 20, 2023
@xkoredev xkoredev force-pushed the kore/cherry-pick-latent-cp branch from 78eac99 to a00e1c5 Compare October 20, 2023 05:29
@xkoredev xkoredev changed the title [core] Fix latent effects not applying when zoning into non conquest areas [core] Fix conquest logs / latent effects not applying when zoning into non conquest areas Oct 20, 2023
* Nation Latent changes.

* Fix nation zone/login issues.

* Remove extra spaces.

Remove extra spaces.

* Simplified logic.
@xkoredev xkoredev force-pushed the kore/cherry-pick-latent-cp branch from a00e1c5 to 63833dc Compare October 20, 2023 05:43
@xkoredev xkoredev closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [xi_map] logging error "Invalid conquest region passed to function"
2 participants