Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Allow external modification of packet guard allow list #4620

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

zach2good
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • [lol, no] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Helps with issue discussed in #1162

@github-actions
Copy link

✨ Thanks for the PR! ✨

This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template.

@TeoTwawki
Copy link
Contributor

[lol, no]

dear contributors, do as i say not as I do. If you copy that on your PRs well..
image

@zach2good
Copy link
Contributor Author

^ I wrote and designed all the involved systems entirely from scratch and I know exactly what I'm doing. Do as I say not as I do 😆.

I would love to be humbled by a very obvious mistake in this PR.

@TeoTwawki
Copy link
Contributor

cafe427825436106c3bb62d42fa04048de22b4b3

@TeoTwawki TeoTwawki merged commit 5e4f933 into base Oct 19, 2023
12 checks passed
@zach2good zach2good deleted the allow_packet_guard_allow_list_modification branch October 19, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants