Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Monstrosity part 2: Battle & Skills #4618

Draft
wants to merge 11 commits into
base: base
Choose a base branch
from
Draft

Conversation

zach2good
Copy link
Contributor

@zach2good zach2good commented Oct 17, 2023

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Translate from 'dat_id' to 'skill_id'
  • Refactor action packet to account for: ℹ️ Packet Information: Action Packets (S->C 0x0028)  #4152
  • Implement the packets for " is readying ", with visuals, timings, etc. (will likely shine light on 🐛 Dynamic Entity: Mobs do not display "Charge Up" on Mobskill #4556)
  • Update "set update" packets with new info from atom0s: https://github.com/atom0s/XiPackets/blob/main/world/server/0x0063/README.md
  • Moves for species (and variants) of:
    • Rabbit
    • Mandy
    • Lizard
    • Bee
  • Correct moves and animations
  • Partial TP spend for MON moves
  • Look and see how broken the balance is for these moves (but balance and polish is PR part 3)
  • Save/load relevant monstrosity family level and remainder exp when zoning
  • Load monstrosity exp tables
  • When in monstrosity, gained exp goes towards your current MON species level, plus your remainder
  • You get 10% (or setting) infamy for exp gained
  • When you learn a new instinct, you get a little lightbulb animation
  • When you get a new variant, do you get any animations?
  • Terry from Feretory's animations when he casts buffs on you
  • The Bee quest guy has more options for unlocking and trading, etc.
  • Make Belligerency icon visible to other players
  • Write out instructions for how to capture and verify commented-out moves, models, mods, etc.
  • Spellcasting for MONs
  • Start looking at and comparing stats and stat generation with tables and captures, but full implementation of this can be in PR part 3
  • Start looking at restricting which abilities/spells/traits MONs get (they don't get Warp as a BLM, etc.)
  • Make sure !givexp n, !changejob x n and other relevant commands work as expected (and their results are saved to the buffers of MON data)
  • Make sure level-based unlocks happen (when relevant) out in the field
  • Sanity check TP move costs and delays

What does this pull request NOT do?

  • Provide a fair, fun, or balanced Monstrosity experience
  • Allow for much/any customisation (it's all baked into the client, we couldn't make it easily customisable even if we wanted to!)
  • Implement much/all content (there's a lot!)

Steps to test these changes

  • Play
  • Use moves
  • Use spells
  • Level up

Following on from #4555

Gist of putting together the new sql table: https://gist.github.com/zach2good/6888948a418d7a6672d2421ed006b4fb

@LandSandBoat LandSandBoat deleted a comment from github-actions bot Oct 18, 2023
@zach2good zach2good added the enhancement New feature request label Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants