Pass wsID to xi.weaponskills.takeWeaponskillDamage() #4614
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Before this patch, PUP's Automaton's ranged attack and weaponskill shows 0 damage done because of an error in xi.weaponskills.takeWeaponskillDamage():
[map][error] luautils::onUseWeaponSkill: ./scripts/globals/weaponskills.lua:1012: bad argument #1 to 'lshift' (number expected, got nil)
Strangely enough, Atonement still correctly shows its damage even though it causes the same error, fix this by passing wsID to xi.weaponskills.takeWeaponskillDamage() as expected.
Steps to test these changes