Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Map>Packets>Various A thru M files: Russian to English #4580

Conversation

EpicTaru
Copy link
Contributor

@EpicTaru EpicTaru commented Oct 3, 2023

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Within /src/map/packets/:
char_jobs.cpp,
char_stats.cpp,
inventory_assign.h,
keyitems.h,
merit_points_categories.cpp,
message_text.cpp

  • Translated Russian comments to English
  • Removed any un-necessary/non-helpful translations/empty comment blocks
    • If more are deemed un-necessary/non-helpful/if I was too strict in my removals, please let me know!
  • Corrected grammar/formatting of any pre-existing comments that I came across during the above processing

Steps to test these changes

No testing necessary, no code was changed, only comments.

* *
************************************************************************/

// TODO: не помню, зачем я сунул это сюда ((
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не помню, зачем я сунул это сюда = I don't remember why I put this here

@zach2good zach2good merged commit b2aea60 into LandSandBoat:base Oct 9, 2023
12 checks passed
@EpicTaru EpicTaru deleted the Map_PacketsFolder_VariousAThruMFiles_RussianToEnglish branch October 9, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants