Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace event cancelled magic number with utils.EVENT_CANCELLED_OPTION #4575

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Replace event cancelled magic number with utils.EVENT_CANCELLED_OPTION #4575

merged 1 commit into from
Oct 2, 2023

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Oct 2, 2023

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Replaces the magic number 1073741824 with utils.EVENT_CANCELLED_OPTION

Steps to test these changes

No changes to gameplay should occur. All globals impacted already require scripts/globals/utils, and all other occurrences are loaded after globals

@claywar claywar merged commit 38ae46f into base Oct 2, 2023
12 checks passed
@claywar claywar deleted the cancelled-event branch October 2, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zach2good zach2good zach2good approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claywar @zach2good