Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change storage method for waypoints to support map markers #4564

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Sep 29, 2023

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Closes #2808

  • Changes index for storing unlocked waypoints to use 2x uint32 fields (from 5)
  • Corrects issues with higher value indices from previous implementation
  • Adds workaround for Western Adoulin waypoint NPC order

Steps to test these changes

Unlock various waypoints:

  • City zones should correctly display unlocked waypoints, and teleport to appropriate locations
  • Non-city zones should only allow transport to unlocked Eastern, Western Adoulin waypoints and unlocked waypoints in current zone

@claywar claywar merged commit 8f2779f into base Sep 29, 2023
12 checks passed
@claywar claywar deleted the waypoint-map branch September 29, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔨 Refactor method used to store Waypoint unlocks
2 participants