Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing augments from mini expansions #4559

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Missing augments from mini expansions #4559

merged 1 commit into from
Oct 22, 2023

Conversation

MowFord
Copy link
Contributor

@MowFord MowFord commented Sep 28, 2023

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds missing augments defined in the Tenshodo Treasure Coffer rewards:

  • Call beast recast reduction
  • Sic/Ready recast reduction
  • Quick Draw recast reduction
  • Waltz cost reduction
  • Barrage shot count increase
  • Phantom recast reduction
  • WS total dmg increase

Steps to test these changes

Set the following mods or purchase tenshodo coffer rewards and use chat commands to send the /ja twice in quick succession to see recast before and after (use !reset between tests for sanity's sake)

  • CALL_BEAST_DELAY
  • SIC_READY_RECAST
  • QUICK_DRAW_RECAST
  • PHANTOM_RECAST

Set waltz_cost mod to X and see waltzes cost X*10 tp less

Set BARRAGE_COUNT and trust that you're getting extra potential hits

@MowFord
Copy link
Contributor Author

MowFord commented Sep 28, 2023

Note that ready and sic do not have a max reduction of 15s, so that was removed

@MowFord
Copy link
Contributor Author

MowFord commented Oct 9, 2023

modifier.h was in conflict due to https://github.com/LandSandBoat/server/pull/4571/files

I think i did a git rebase properly. First time.

Call beast recast reduction
Sic/Ready recast reduction
Quick Draw recast reduction
Waltz cost reduction
Barrage shot count increase
Phantom recast reduction
WS total dmg increase
@zach2good zach2good added enhancement New feature request and removed enhancement New feature request labels Oct 22, 2023
@zach2good zach2good merged commit 85f1c2e into LandSandBoat:base Oct 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants