[Fix] Souleater effect modifier stacking #4557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaver-DaRed
changed the title
Xaver-DaRed
force-pushed
the
WSoul
branch
2 times, most recently
from
b2d9f56 to
a741921
Compare
zach2good
reviewed
Sep 28, 2023
zach2good
approved these changes
Oct 20, 2023
src/map/lua/lua_baseentity.cpp
Outdated
| } | ||
| } | ||
| return maxModValue; | ||
| return static_cast<CBattleEntity*>(m_PBaseEntity)->getMaxGearMod(static_cast<Mod>(modId)); |
There was a problem hiding this comment.
Inside the function that this calls, you're checking for whether or not this is a Char entity, so why not cast to a char here?
There was a problem hiding this comment.
Changed it to CCharEntity*
src/map/lua/lua_baseentity.cpp
Outdated
| { | ||
| ShowWarning("CLuaBaseEntity::getMaxGearMod() - m_PBaseEntity is not a player."); | ||
| ShowWarning("Invalid Entity (NPC: %s) calling function.", m_PBaseEntity->GetName()); |
There was a problem hiding this comment.
This could get called on a Pet or a Mob, not necessarily just an NPC
There was a problem hiding this comment.
Changed it to Non-PC, since it is meant for player characters only.
Xaver-DaRed
added
enhancement
TeoTwawki
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
As per this BG article https://www.bg-wiki.com/ffxi/Souleater
Equipment that enhances Souleater (Souleater +X) does not stack. An exception happens with augments.
This PR (attempts to):
getMaxGearMod()which returns the highest value of a modifier found in gear, insstead of the total value.Steps to test these changes
Use Souleater with different pieces of gear that enhance Souleater and see if it only takes the higest value.