[LUA] Fixes self target in "!givemagianitem" command #4551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claywar
reviewed
Sep 26, 2023
| @@ -32,7 +32,7 @@ commandObj.onTrigger = function(player, target, trialId, isRewardItem) | |||
| player:PrintToPlayer(string.format('Player \'%s\' does not have free space for that item!', target)) | |||
| else | |||
| if giveRewardItem then | |||
| xi.magian.giveRewardItem(player, trialId) | |||
| xi.magian.giveRewardItem(target, trialId) | |||
There was a problem hiding this comment.
This isn't an entirely accurate fix, and only half-implements your desired intent. I'm fine with requiring a target, but you didn't update the else condition, which in this case, giveRewardItem bool determines if its the requiredItem or rewardItem in the magian table.
There was a problem hiding this comment.
I updated the additional player to target
N3ckB3ard
force-pushed
the
fix_magian_command
branch
from
587f63d to
d4c6f3a
Compare
Xaver-DaRed
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Corrects issue with "target" in the !givemagianitem command
Steps to test these changes
Use command and give the item to a player, rather than yourself