Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Change damageType LIGHTNING to THUNDER #4544

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

Xaver-DaRed
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed commented Sep 24, 2023

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

We had both xi.damageType.LIGHTNING and xi.damageType.THUNDER cases of damageType existing in the code. One had to be chosen.

"But why was THUNDER chosen over LIGHTNING? I liked LIGHTNING"
Because THUNDER is shorter AND aligns with the element naming of xi.element table.

Steps to test these changes

Some things may work properly now?

@claywar claywar merged commit 41b0cfb into LandSandBoat:base Sep 30, 2023
11 checks passed
@Xaver-DaRed Xaver-DaRed deleted the Thundaga branch October 10, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants