Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add padding check for logical operators #4537

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

claywar
Copy link
Contributor

@claywar claywar commented Sep 22, 2023

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Adds checks for all lines to ensure the logical operators "and" and "or" do not contain excess padding (Note: Need to handle not as a special case in the future, since indented lines can start with this
  • Corrects scripts failing this new check

Steps to test these changes

CI should pass

@claywar claywar marked this pull request as draft September 22, 2023 10:06
@claywar claywar force-pushed the ci/operator-padding branch 2 times, most recently from 8529085 to b8c32bc Compare September 22, 2023 10:39
@claywar claywar force-pushed the ci/operator-padding branch from b8c32bc to 40c96cb Compare September 22, 2023 10:55
Modify regex, add todo for other items noticed

Remove debug setting

Verify correct fail count for self-tests and update

Add excess padding checks for operators
@claywar claywar force-pushed the ci/operator-padding branch from 40c96cb to 435273e Compare September 22, 2023 12:05
@claywar claywar marked this pull request as ready for review September 22, 2023 12:08
@claywar claywar merged commit 89d17e2 into base Sep 22, 2023
11 checks passed
@claywar claywar deleted the ci/operator-padding branch September 22, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants