Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL][Item] Mods 23097-23101 #4531

Merged
merged 1 commit into from
Sep 30, 2023
Merged

[SQL][Item] Mods 23097-23101 #4531

merged 1 commit into from
Sep 30, 2023

Conversation

helixhamin
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Per title, adds item mods, and needed latents and pet mods, to items 23097-23101.
It also corrects some BP_DAMAGE mods that were incorrectly in the item_mods, instead of item_pet_mods table.
And, one misspelling correction.

Steps to test these changes

As GM, !additem 23097|23098|23099|23100|23101
Check to make sure the changes in attributes apply.

@helixhamin
Copy link
Contributor Author

Sorry, repushed, since I double checked item 26677, Apogee Crown +1, and noticed it does not even have BP Damage mod. The set does, the piece itself does not, so transferring from item_mods to item_pet_mods was not accurate. I did add the missing pet mods though for this armor, since it already had all the item_mods. I will check the set mods as I confirm JSE.

@helixhamin helixhamin changed the title [SQL][Item] Adds item mods to 23097-23101 [SQL][Item] Mods 23097-23101 Sep 21, 2023
@claywar claywar merged commit a8aaab5 into LandSandBoat:base Sep 30, 2023
11 checks passed
@helixhamin helixhamin deleted the item_mods_23097-23101 branch October 1, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants