DRG AF Quest: "Knight Stalker" NM Spawn Fix

[UmeboshiXI]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Allows the 2 shadow NMs to spawn when:

• Player is DRG.
• Player has pet wyvern out and alive.

Previously the NMs would not spawn as intended, stopping quest progression.

Steps to test these changes

• `!changejob drg 75' and flag quest (or comment out the charvar quest requirements).
• !gotoid 17428862
• Use Call Wyvern.
• Click on ??? (ID:17428862).
• See that 2 shadow NMs spawn.

Note: In future, this quest should be converted to the new framework but this will allow the quest to function in the mean time.

[zach2good]

Logically, does this allow 2x different players to spawn the NM at the same time? I believe thats why npcUtil.popFromQM is in the if block, because it checks for such a scenario

I hadn't thought of Zach's scenario

[zach2good]

player:getPet() can only return a valid CLuaBaseEntity or nil, checking pet and pet ~= nil are equivalent if the pet has come out correctly, what did you observe here?

[zach2good]

std::optional<CLuaBaseEntity> CLuaBaseEntity::getPet()
{
    auto* PBattle = static_cast<CBattleEntity*>(m_PBaseEntity);

    if (PBattle->PPet != nullptr)
    {
        return std::optional<CLuaBaseEntity>(PBattle->PPet);
    }

    return std::nullopt;
}

[UmeboshiXI]

Might end up closing this. Could be something weird on my end? I wasn't getting any lua errors. When I restarted my server/client, it happened to work fine afterwards. Before it was just not popping or displaying a message.