🐛 Dynamic Entity: Mobs do not display "Charge Up" on Mobskill

[UmeboshiXI]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

• Give yourself GM Level 5
• Use !fafnir command
• !tp 3000 on Fafnir, See that the normal charge up animation does not display when the mob is readying its move.

Expected behavior

Mob should display the charging animation + accompanying sound effect when readying a mob skill.

[CatsEyeXI]

confirmed

[zach2good]

This might be a limitation of DEs. They're getting all the same packets as regular mobs, the messaging is the same, the mob itself goes into the charging stance until the move goes off, they arrive in the correct order, etc.

There's some refactoring of the action packet to come with my Monstrosity work, but those animations are working fine on Mob-type entities and now on Player-type entities, so it's unknown right now if this is possible to fix.

[zach2good]

One way to skirt this (as is the way of all custom things) is to abuse the client:

If someone was patient enough, they could try and find the actual animation that plays when a mob charges up, and send in an IndependantAnimation packet at the start of MobSkillState if the entity is a DE.

https://github.com/LandSandBoat/server/blob/base/src/map/lua/lua_baseentity.cpp#L11202
https://github.com/LandSandBoat/server/blob/base/src/map/ai/states/mobskill_state.cpp#L75

I've been testing on Fafnir with !exec target:independentAnimation(target, 234, 2) and swapping out numbers

[zach2good]

I won't be sinking any time into trying to find a combo of animations that works for this, it's too minor of a visual effect omission

[UmeboshiXI]

Understandable. I have been mapping out animations on my spare time too. If I run into something resembling the correct animation I'll post an update.