Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging from google-research's repo to update this one. #1

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

haamis
Copy link

@haamis haamis commented Jul 29, 2019

I'm suggesting merging changes from Google's BERT repo into this one, mainly to enable whole word masking when using this repo. The relevant changes are in create_pretraining_data.py and modeling.py. The two repos seem to merge very cleanly and none of the code changed to use Horovod seem to be affected.

@haamis haamis marked this pull request as ready for review July 29, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants