Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS CI #7572

Merged
merged 9 commits into from
Nov 6, 2024
Merged

Update macOS CI #7572

merged 9 commits into from
Nov 6, 2024

Conversation

messmerd
Copy link
Member

@messmerd messmerd commented Nov 5, 2024

GitHub is removing the macOS 12 build runners on December 3, and is removing XCode 14 and 16 from macOS 14 on November 4 (today!).

This PR:

  • Updates our macOS x86-64 build runner from macOS 12 to macOS 13
  • Updates our macOS x86-64 XCode version from 13.1 to 15.2
  • Updates our macOS ARM64 XCode version from 14.3.1 to 15.4
  • Fixes a number of compiler warnings on macOS
    • Note: There are still some sprintf deprecation warnings coming from 3rd party libraries, but all usages of sprintf in LMMS itself have been converted to std::snprintf

Copy link
Contributor

@JohannesLorenz JohannesLorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved:

  • Functional review OK ✔️
  • Style review OK ✔️
  • Test review OK ✔️

IMO, no 2nd review is required here.

src/core/ProjectRenderer.cpp Show resolved Hide resolved
@messmerd messmerd merged commit e36463c into LMMS:master Nov 6, 2024
11 checks passed
@messmerd messmerd deleted the macos-upgrade branch November 6, 2024 22:56
@messmerd messmerd added macos CI Issues/pull requests regarding continuous integration(CI) system labels Nov 20, 2024
rubiefawn pushed a commit to rubiefawn/lmms that referenced this pull request Nov 28, 2024
* Use macOS 13

See: actions/runner-images#10721

* Upgrade to XCode 15.2

XCode 15.2 is the default on macOS 13

* Fix unqualified call to std::move warning

* Fix sprintf deprecated warnings

* Upgrade macOS 14 ARM64 builds to XCode 15.4

See: actions/runner-images#10703

* Fix unused lambda capture warnings in Fader.cpp

* Fix unused variable warnings

* Fix formatting warning

Cannot format `const void*` as a string

* Force lambda conversion to function pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues/pull requests regarding continuous integration(CI) system macos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants