Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resize issues #7524

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

JohannesLorenz
Copy link
Contributor

This is a split-of from lv2-ui which consists of many things I had to do to display Lv2 effects properly (and possibly fix other bugs).

I am still not finished with checking which of the changes do what, and which are unnecessary.

This is already uploaded for documentational purposes.

@Rossmaxx
Copy link
Contributor

Rossmaxx commented Oct 3, 2024

@JohannesLorenz i believe #7438 (and a follow up for resizeability) will fix the glitch better than working on the existing effect view.

@JohannesLorenz
Copy link
Contributor Author

@JohannesLorenz i believe #7438 (and a follow up for resizeability) will fix the glitch better than working on the existing effect view.

My PR does not touch effects at all. So what you say may be true (in a trivial way), but does not make my PR wrong or unnecessary.

@JohannesLorenz
Copy link
Contributor Author

JohannesLorenz commented Nov 23, 2024

Open issue: TripleOsc can be resized in this PR. This should not be possible. I have to find out why. Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants