Fix bugs in Sample::play
#7408
Closed
Fix bugs in Sample::play
#7408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wont occur unless something really bad happens for some reason, so an assert is used.
|
@sakertooth is there a way i can obtain a build or do i have to build it myself |
Apologies, there was an error with the build. It should be here. |
1 task
|
I edited the message to provide a proper link to the build. It should be up there now. |
|
It didn't fix anything. I'll try your new commit once it's built. Would it be the same URL? |
|
It didn't? I'm not sure then. Still a good PR to merge I guess, but I'm surprised it fixed nothing. And yeah, the latest builds should always be at that link. |
|
latest build has the same behaviour |
|
Closing in favor of the revert at #7410. It should be fixed there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed an edge case in #7361.
src_callback_readreturns the number of frames generated or zero. That means that it is not necessarily the case thatsrc_callback_readwill return the number of frames requested all the time. Also checked for a potential error (that really shouldn't ever happen) on calls tosrc_set_ratiowith anassert.Fixes #7400 (I think?)
Fixes #7395 (I think?)