Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup of #7381 #7401

Merged
merged 3 commits into from
Jul 28, 2024
Merged

Fixup of #7381 #7401

merged 3 commits into from
Jul 28, 2024

Conversation

JohannesLorenz
Copy link
Contributor

Fixup of commit 9c0fc8f

@JohannesLorenz
Fixup of LMMS#7381
6297392 
Fixup of commit 9c0fc8f
@JohannesLorenz
Copy link
Contributor Author

JohannesLorenz commented Jul 28, 2024 •
edited
Loading

@bratpeki please additionally review this, especially make sure this still solves the issue from this comment: #7381 (comment)

I will also review this. Strangely, I cannot self-request my review.

@JohannesLorenz JohannesLorenz merged commit 0d3c43d into LMMS:master Jul 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rossmaxx Rossmaxx Rossmaxx left review comments

@bratpeki bratpeki bratpeki approved these changes

@LostRobotMusic LostRobotMusic LostRobotMusic approved these changes

Assignees
No one assigned
Labels
bug critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohannesLorenz @LostRobotMusic @bratpeki @Rossmaxx