-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lossless image optimization #294
base: master
Are you sure you want to change the base?
Conversation
Thanks for your PR! How did you optimize these images though? Also, looks like the changes weren't totally lossless, rather they were too small to notice. |
It's just SVG compression and only lossless algorithms were used! |
Okay then. I can see you also introduced |
Worth noting that zopflipng does truly visually lossless compression. (In other words, the resulting pixel data shown will be identical to the original, but stuff like metadata that doesn't affect pixel color might be lost.) For this case though, perceptually lossless seems fine. Zopfli beats PNGOut, and PNGOut beats OptiPNG. If we're ok with lossy, pngquant appears to be a good choice. |
Also, SVG compression doesn't explain how the PNGs were compressed, which is the majority of the changes in this PR. |
PNGQuant beat OPs compression for logo and project icons at large and medium sizes. Otherwise OPs is better. img - quant.zip However, I think we should leave the logo and project images (truly) lossless, since they're provided for download in the branding section they should be as high quality as possible. |
Looks like this PR went stale. To summarize, the OP probably need to:
Otherwise LGTM |
@liushuyu Sure for the .DS_store However, this is lossless optimization --> quality is not affected! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FlipFloop Once you've removed public/.DS_Store
, this will be good to merge.
No description provided.