Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lossless image optimization #294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

FlipFloop
Copy link

No description provided.

@liushuyu
Copy link
Member

liushuyu commented Mar 8, 2020

Thanks for your PR! How did you optimize these images though? Also, looks like the changes weren't totally lossless, rather they were too small to notice.

@FlipFloop
Copy link
Author

It's just SVG compression and only lossless algorithms were used!

@liushuyu
Copy link
Member

It's just SVG compression and only lossless algorithms were used!

Okay then.

I can see you also introduced public/.DS_Store file which I think it's unintended. Would mind removing it?

@Spekular
Copy link
Member

Spekular commented Mar 10, 2020

Also, looks like the changes weren't totally lossless, rather they were too small to notice.

Worth noting that zopflipng does truly visually lossless compression. (In other words, the resulting pixel data shown will be identical to the original, but stuff like metadata that doesn't affect pixel color might be lost.) For this case though, perceptually lossless seems fine.

Zopfli beats PNGOut, and PNGOut beats OptiPNG. If we're ok with lossy, pngquant appears to be a good choice.

@Spekular
Copy link
Member

Also, SVG compression doesn't explain how the PNGs were compressed, which is the majority of the changes in this PR.

@Spekular
Copy link
Member

PNGQuant beat OPs compression for logo and project icons at large and medium sizes. Otherwise OPs is better. img - quant.zip

However, I think we should leave the logo and project images (truly) lossless, since they're provided for download in the branding section they should be as high quality as possible.

@liushuyu
Copy link
Member

Looks like this PR went stale.

To summarize, the OP probably need to:

  1. Remove all the .DS_Store clutter
  2. lmms-64x64.svg lmms-project-64x64.svg logo_lg.png project_lg.png should not be compressed since these files are meant to be downloaded in full quality with all the metadata intact (see https://lmms.io/branding)

Otherwise LGTM

@FlipFloop
Copy link
Author

@liushuyu Sure for the .DS_store

However, this is lossless optimization --> quality is not affected!

Copy link
Member

@lukas-w lukas-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FlipFloop Once you've removed public/.DS_Store, this will be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants