Skip to content

Commit

Permalink
Merge pull request #14 from LFDT-Lockness/dt
Browse files Browse the repository at this point in the history
Remove slip10-like derivation and add stark-specific derivation
  • Loading branch information
survived authored Dec 4, 2024
2 parents 980c062 + 158b65c commit c0053fb
Show file tree
Hide file tree
Showing 14 changed files with 1,113 additions and 310 deletions.
25 changes: 21 additions & 4 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,24 +9,41 @@ env:
CARGO_NET_GIT_FETCH_WITH_CLI: true

jobs:
build-no-features:
check-no-features:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
with:
cache-on-failure: "true"
- name: Build
run: cargo build
build-and-test-all-features:
run: cargo check --no-default-features
check:
runs-on: ubuntu-latest
strategy:
matrix:
features:
- slip10
- slip10,curve-secp256k1
- slip10,curve-secp256r1
- edwards
- stark
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
with:
cache-on-failure: "true"
- name: Build
run: cargo build --all-features
run: cargo check --features ${{ matrix.features }}
check-and-test-all-features:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
with:
cache-on-failure: "true"
- name: Build
run: cargo check --all-features
- name: Run tests
run: cargo test --all-features --lib --tests
doctest:
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# hd-wallet crate changelog

## v0.6.0
* Remove slip10-like derivation that can be instantiated with any curve: it is very inefficient
when instantiated with certain curves, and may also enable attacker to perform DoS attack by
finding derivation path that results into very long computation [#14]
* Add stark-specific derivation: secure and efficient derivation for stark curve [#14]

[#14]: https://github.com/LFDT-Lockness/hd-wallet/pull/14

## v0.5.1
* Update docs and repo link [#11]

Expand Down
174 changes: 171 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit c0053fb

Please sign in to comment.