Add endpoint for decoding invoices #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louneskmt
suggested changes
May 1, 2022
There was a problem hiding this comment.
Thanks @w3irdrobot! Could you add: timestamp, min_final_cltv_expiry, route_hints, features and payee_pub_key as well? Then we should have all the necessary fields, like the other implems.
|
can you add grpc support for this as well? it shouldn't be much more since both grpc/http both use the same service implementation you already wrote. will just need to update the proto and then the grpc/node.rs implementation for it. I'd like to make sure we don't let the grpc interface fall behind. also can you rebase and fix the conflict in src/services/node.rs --- let me know if you need help there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #21. Requested by @louneskmt. This should work. I kind of guessed what information would be needed from the endpoint. 🤷♂️