feat: add interceptors for http and graphql client to support multiple subgraph api keys #669
+1,015
−580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhnhathoang
changed the title
Test coverage changes:
|
minhnhathoang
force-pushed
the
feat/multiple-thegraph-api-keys
branch
3 times, most recently
from
9c9f537 to
9cc5946
Compare
minhnhathoang
changed the title
minhnhathoang
force-pushed
the
feat/multiple-thegraph-api-keys
branch
from
1166e3a to
2049ee5
Compare
minhnhathoang
force-pushed
the
feat/multiple-thegraph-api-keys
branch
from
2049ee5 to
95d706c
Compare
minhnhathoang
requested review from
piavgh,
it4rb,
NgoKimPhu and
lehainam-dev
as code owners
sunspirit99
reviewed
Jan 3, 2025
| } | ||
|
|
||
| func NewPoolsListUpdater( | ||
| cfg *Config, | ||
| graphqlClient *graphqlpkg.Client, | ||
| graphqlClientCfg *graphqlpkg.Config, |
There was a problem hiding this comment.
I don't see this graphqlClientCfg being used anywhere in this file
There was a problem hiding this comment.
oh, graphqlClient is initialized with config from pool-service. I removed redundant code
|
|
||
| var response struct { | ||
| Pools []SubgraphPool `json:"pools"` | ||
| } | ||
|
|
||
| if err := d.graphqlClient.Run(ctx, req, &response); err != nil { | ||
| if err, _ := d.graphqlClient.Run(ctx, req, &response); err != nil { |
There was a problem hiding this comment.
I think we're more familiar with convention of returning the error at the last position 
| "github.com/pkg/errors" | ||
| ) | ||
|
|
||
| type IClient interface { |
There was a problem hiding this comment.
Is this interface complete with all the required methods ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why did we need it?
Related Issue
Release Note
How Has This Been Tested?
Screenshots (if appropriate):