-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate frxeth, meth, and ondo-usdy #551
Conversation
Test coverage changes:
|
4309a57
to
29c6b66
Compare
|
||
var ( | ||
defaultGas = Gas{ | ||
Stake: 130000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last time I asked to increase this to 130k, I forgot that there's an overhead for any tx, which is about 30k. so let's reduce this to 100k, thanks and sorry for the trouble
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we calculate this number as the average of gasUsed based on the tx receipts? In this case, the average gas is approximately 150,000 (214 transactions from block 21036737 to 20936737 (100,000 blocks)), so should we adjust it to 120,000 instead?
Co-authored-by: Phu Ngo <[email protected]> Signed-off-by: minhnhathoang <[email protected]>
Co-authored-by: Phu Ngo <[email protected]> Signed-off-by: minhnhathoang <[email protected]>
Co-authored-by: Phu Ngo <[email protected]> Signed-off-by: minhnhathoang <[email protected]>
34e9a04
to
46c70b0
Compare
Why did we need it?
Related Issue
Release Note
How Has This Been Tested?
Screenshots (if appropriate):