Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate frxeth, meth, and ondo-usdy #551

Merged
merged 18 commits into from
Oct 25, 2024
Merged

Conversation

minhnhathoang
Copy link
Member

Why did we need it?

Related Issue

Release Note

How Has This Been Tested?

Screenshots (if appropriate):

Copy link

github-actions bot commented Oct 22, 2024

Test coverage changes:
Package Before After Diff
github.com/KyberNetwork/kyberswap-dex-lib/pkg/entity 27.40% 27.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/ambient 12.00% 12.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v1 29.80% 33.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v2/composable-stable 36.80% 38.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v2/math 49.00% 49.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v2/stable 21.40% 25.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/balancer-v2/weighted 29.10% 32.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/bancor-v21 25.30% 25.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/bancor-v3 35.30% 37.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/bebop 34.60% 34.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/bedrock/unieth 6.20% 6.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/curve/plain 21.10% 22.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/curve/stable-meta-ng 9.00% 10.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/curve/stable-ng 11.30% 12.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/curve/tricrypto-ng 23.60% 24.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/curve/twocrypto-ng 22.90% 23.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dai-usds 10.70% 18.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dodo/classical 28.20% 31.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dodo/dpp 12.30% 16.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dodo/dsp 12.80% 16.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dodo/dvm 13.40% 17.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dodo/libv1 73.30% 73.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/dodo/libv2 37.60% 37.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/ether-vista 2.10% 2.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/etherfi/eeth 8.00% 8.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/etherfi/weeth 6.40% 6.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/fluid/vault-t1 9.60% 9.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/generic-simple-rate 17.60% 22.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/gyroscope/2clp 30.70% 30.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/gyroscope/3clp 32.90% 32.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/gyroscope/eclp 50.40% 50.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/gyroscope/math 14.30% 14.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/hashflow-v3 37.90% 37.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/integral 22.20% 26.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/kelp/rseth 7.10% 7.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/mantle/meth 0.00% 14.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/mkr-sky 14.60% 21.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/native-v1 32.50% 32.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/nomiswap/nomiswapstable 6.60% 8.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/ondo-usdy 0.00% 15.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/puffer/pufeth 11.00% 11.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/renzo/ezeth 5.80% 5.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/ringswap 7.10% 8.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/rocketpool/reth 10.70% 10.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/staderethx 15.80% 15.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/swaap-v2 20.90% 27.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/swell/rsweth 4.40% 4.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/swell/sweth 4.40% 4.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/uniswap-v1 8.90% 13.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/uniswap-v2 7.70% 9.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/usd0pp 14.00% 14.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/velocore-v2/cpmm 40.80% 43.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/velocore-v2/math 16.80% 16.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/velocore-v2/math/sd59x18 51.90% 51.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/velocore-v2/wombat-stable 19.30% 24.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/velodrome-v1 26.60% 29.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/velodrome-v2 28.80% 32.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/woofi-v2 37.80% 41.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/liquidity-source/woofi-v21 33.30% 36.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/algebrav1 19.00% 20.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/balancer-composable-stable 40.40% 42.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/balancer/stable 29.80% 33.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/balancer/weighted 29.80% 32.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/camelot 27.80% 32.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/aave 19.10% 20.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/base 11.80% 13.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/compound 11.30% 12.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/meta 21.60% 22.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/plain-oracle 10.10% 11.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/tricrypto 25.10% 26.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/curve/two 11.20% 12.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/dmm 19.70% 25.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/dodo 28.70% 31.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/equalizer 18.20% 23.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/fraxswap 13.60% 18.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/fulcrom 22.20% 25.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/fxdx 17.20% 19.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/gmx 24.20% 25.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/gmx-glp 22.60% 23.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/iziswap 19.60% 23.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/kokonut-crypto 19.90% 21.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/kyber-pmm 9.80% 13.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/lido 15.80% 21.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/lido-steth 12.90% 18.40% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/limitorder 29.80% 32.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/liquiditybookv20 25.10% 27.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/liquiditybookv21 33.30% 35.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/madmex 21.70% 23.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/makerpsm 23.70% 29.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/mantisswap 33.40% 36.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/maverickv1 49.20% 50.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/metavault 24.00% 25.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/nuriv2 15.80% 19.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/pancakev3 22.60% 25.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/platypus 18.90% 22.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/pol-matic 7.90% 15.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/quickperps 17.80% 19.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/ramsesv2 15.80% 19.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/saddle 47.10% 50.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/slipstream 15.30% 15.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/smardex 30.30% 34.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/solidly-v3 18.30% 21.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/swapbased-perp 23.70% 25.30% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/syncswap/syncswapclassic 20.30% 25.10% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/syncswap/syncswapstable 28.90% 33.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/synthetix 32.50% 33.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/traderjoev20 2.70% 2.70% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/traderjoev21 2.60% 2.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/uniswap 15.60% 16.90% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/uniswapv3 30.50% 32.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/usdfi 29.00% 34.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/velocimeter 30.20% 35.20% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/velodrome 29.20% 34.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/velodromev2 29.80% 34.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/vooi 22.30% 27.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/wombat/wombatlsd 20.40% 23.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/wombat/wombatmain 20.70% 23.80% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/source/woofiv2 36.50% 40.60% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/util 4.50% 4.50% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/util/abi 75.00% 75.00% ✔️
github.com/KyberNetwork/kyberswap-dex-lib/pkg/util/bignumber 16.70% 16.70% ✔️

@minhnhathoang minhnhathoang changed the title feat: integrate meth feat: integrate frxeth, meth, and ondo-usdy Oct 24, 2024

var (
defaultGas = Gas{
Stake: 130000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last time I asked to increase this to 130k, I forgot that there's an overhead for any tx, which is about 30k. so let's reduce this to 100k, thanks and sorry for the trouble

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we calculate this number as the average of gasUsed based on the tx receipts? In this case, the average gas is approximately 150,000 (214 transactions from block 21036737 to 20936737 (100,000 blocks)), so should we adjust it to 120,000 instead?

@minhnhathoang minhnhathoang merged commit 0b77c2d into main Oct 25, 2024
5 checks passed
@minhnhathoang minhnhathoang deleted the feat/integrate-meth branch October 25, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants