Correct formular to calculate filledMakingAmountWei

KyberNetwork · Dec 18, 2024 · 10541b5 · 10541b5
1 parent adf23e3
commit 10541b5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pkg/source/limitorder/pool_simulator.go b/pkg/source/limitorder/pool_simulator.go
@@ -249,9 +249,9 @@ func (p *PoolSimulator) calcAmountOutWithSwapInfo(swapSide SwapSide, tokenAmount
 		if remainingTakingAmountWei.Cmp(totalAmountInAfterFee) >= 0 {
 			filledTakingAmountWei := totalAmountInAfterFee
 			filledMakingAmountWei := new(big.Int).Div(
-				new(big.Int).Mul(filledTakingAmountWei, remainingMakingAmountWei),
-				remainingTakingAmountWei,
-			) // filledMakingAmountWei = filledTakingAmountWei * remainingMakingAmountWei / remainingTakingAmountWei
+				new(big.Int).Mul(filledTakingAmountWei, order.MakingAmount),
+				order.TakingAmount,
+			) // filledMakingAmountWei = filledTakingAmountWei * order.MakingAmount / order.TakingAmount
 
 			// order too small
 			if filledMakingAmountWei.Sign() <= 0 {