Integration tests #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-kryha
reviewed
Nov 2, 2023
agoric/contract/test/swingsetTests/bootstrap/bootstrap-inventory.js
Outdated
Show resolved
Hide resolved
carlos-kryha
reviewed
Nov 3, 2023
| /** @type {Context} */ | ||
| const { publicFacet, governorFacets, contractAssets, purses, zoe } = context; | ||
|
|
||
| await E(governorFacets.creatorFacet).setFilters(['mintCharacterNfts']); |
There was a problem hiding this comment.
I'm wondering how to revert this, maybe await E(governorFacets.creatorFacet).setFilters([]);?
There was a problem hiding this comment.
I havent really looked into this but what you wrote makes sense. It should really affect the tests though cause each test file runs independent of the others.
There was a problem hiding this comment.
yeah that makes sense, I'll check with Agoric about this
carlos-kryha
reviewed
Nov 7, 2023
carlos-kryha
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new test setup based on test-fluxAggregator-service-upgrade.js
index.jscontract method fromstarttoprepareto allow contract upgrades