feat: add support for forbidding environment variables in gitops files #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new check can be enabled by adding: ``` additionalChecks: ["forbiddenEnvironmentVariables"] ``` in the schema definition.
yannrouillard
force-pushed
the
feat/add-support-for-forbidding-env-variables
branch
from
27cfd71 to
e506f9d
Compare
| FORBIDDEN_ENVIRONMENT_VARIABLES = { | ||
| "KAFKA_APPLICATION_ID": """KAFKA_APPLICATION_ID is automatically set in your container and should not be overridden. | ||
| More info at https://kpler.atlassian.net/l/cp/jb4uJQs3#Use-connection-information-in-environment-variables""", | ||
| "KAFKA_BOOTSTRAP_SERVERS": """KAFKA_BOOSTRAP_SERVERS is automatically set in your container and should not be overridden. |
There was a problem hiding this comment.
@yannrouillard there is a typo BOOSTRAP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new check is used first to ensure that no one override by mistake environment variables set for easy Kafka configuration and that is required to have the permissions working.
It can be enabled by adding:
in the schema definition.