Implemented aggregate reports #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great news :) was waiting for this actual feature so much. |
sandwwraith
reviewed
Dec 16, 2021
src/functionalTest/kotlin/kotlinx/kover/test/functional/cases/utils/Commons.kt
Outdated
Show resolved
Hide resolved
|
|
||
| internal const val DEFAULT_XML = "reports/kover/report.xml" | ||
| internal const val DEFAULT_HTML = "reports/kover/html" | ||
| internal fun defaultXmlReport() = "reports/kover/report.xml" |
There was a problem hiding this comment.
Why these are functions, not vals?
There was a problem hiding this comment.
This is done because at the moment there is no certainty that additional parameters will not be needed to get the default value (for example, as in the case of defaultBinaryReport). So it turns out the general style that getting all the values is a functions, and not a mixture of val and fun.
However, I do not insist on such a decision, if val is perceived better, I can change it.
Co-authored-by: Leonid Startsev <[email protected]>
sandwwraith
approved these changes
Dec 22, 2021
Co-authored-by: Leonid Startsev <[email protected]>
Co-authored-by: Leonid Startsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20, #43