Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the config.ps1 is not locked before accessing it from the init.ps1 script. #270

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

steffen-wilke
Copy link
Contributor

This implements the suggestions I described in detail with Issue #269.
Once merged, this Closes #269

@KostyaSha
Copy link
Owner

Btw, for linux implementation there is suggestion to add additional timeout for the whole wait of this file to not have running containers on corner cases, would you like implement it for win?

@steffen-wilke
Copy link
Contributor Author

Do you refer to #252? I can have a look at a windows implementation here. When I read this correctly you wanted to make this configurable from the UI?

@KostyaSha
Copy link
Owner

Like current settings passed to config, in script it's possible to insert timeout into waiting script

@steffen-wilke
Copy link
Contributor Author

Sure. What value would you suggest here? As far as I understand this option wasn't added to the UI just yet. #252 adds a hardcoded 60 seconds timeout.
So if you want me to I can add an option to the UI and then make sure that the timeout works on windows containers. I think we should maybe do this in a separate PR.

@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #270 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #270   +/-   ##
=========================================
  Coverage     19.19%   19.19%           
  Complexity      248      248           
=========================================
  Files            74       74           
  Lines          3079     3079           
  Branches        295      295           
=========================================
  Hits            591      591           
  Misses         2427     2427           
  Partials         61       61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22e6fe...af78779. Read the comment docs.

@KostyaSha
Copy link
Owner

I will merge current code, timeout could be added later.

@KostyaSha KostyaSha merged commit cf89724 into KostyaSha:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container uses config.ps1 while it's still locked - Running the container fails with Exitcode 1
3 participants