issues/238 add jnlp tunnel configuration #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KostyaSha
reviewed
Jul 14, 2018
| @Override | ||
| public ComputerLauncher getLauncher() { | ||
| return new JNLPLauncher(); | ||
| return new JNLPLauncher(tunnel, jvmOpts); |
There was a problem hiding this comment.
Change here is not needed, real launcher is returned in method before.
There was a problem hiding this comment.
without this change tunnel is not there in slave-agent.jnlp endpoint
i guess it is because of this change in 2.83
jenkinsci/jenkins@257cc23
mb we need to update dependecy in pom to 2.83
There was a problem hiding this comment.
so for rendering options on jnlp url they use delegated launcher instead of root launcher now?
KostyaSha
reviewed
Jul 15, 2018
| cloneJNLPlauncher.setJenkinsUrl(getJenkinsUrl()); | ||
| cloneJNLPlauncher.setNoCertificateCheck(isNoCertificateCheck()); | ||
| cloneJNLPlauncher.setNoReconnect(isNoReconnect()); | ||
|
|
||
| return cloneJNLPlauncher; | ||
| } | ||
|
|
||
| public String getTunnel() { |
There was a problem hiding this comment.
Please move getter after coressponding setter. Class organised in the next way: firstly field getters/setters, then overrides and additional methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI
I'm adding this PR for jnlp tunnels for jenkins installations running behind proxy, where jnlp port is exposed on another host and/or port.
refer to issues/238