Improvement/profile editing #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilbedawg
requested review from
shepherd-06,
samuelhelen,
melinaruu and
pinskii
…ew data from the server after automatically
…value in the socket connection file
vilbedawg
force-pushed
the
improvement/profile-editing
branch
from
e6580d1
to
5ae64d0
Compare
melinaruu
approved these changes
Dec 9, 2023
Not necessarily as of now, but in the future, it might be necessary depending on if some data is stored in the authentication token. Also, I think most sites I've used usually require you to either refresh or re-login. |
|
yeah i guess im more used to a refresh and was thinking about it from the user experience perspective. but i guess this works too. after all its not that often that a use changes their info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored profile editing view with the required features (delete/edit information) + some minor tweaks non-related to this PR, but included them anyways since we are in a hurry!