fix(*): remove vue-bind-once [KHCP-14269] #2535
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
portikM
changed the title
portikM
requested review from
kongponents-bot,
adamdehaven,
jillztom,
kaiarrowood,
Justineo and
a team
as code owners
adamdehaven
reviewed
Dec 9, 2024
adamdehaven
reviewed
Dec 9, 2024
Co-authored-by: Adam DeHaven <[email protected]>
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR: |
Justineo
reviewed
Dec 11, 2024
| @@ -110,7 +109,7 @@ const emit = defineEmits<{ | |||
| const slots = useSlots() | |||
| const attrs = useAttrs() | |||
|
|
|||
| const inputId = attrs.id ? String(attrs.id) : useUniqueId() | |||
| const inputId = attrs.id ? String(attrs.id) : useId() | |||
There was a problem hiding this comment.
Suggested change
| const inputId = attrs.id ? String(attrs.id) : useId() | |
| const id = useId() | |
| const inputId = computed(() => attrs.id ? String(attrs.id) : id) |
I think now this should be a computed ref as we now support dynamic user defined id.
There was a problem hiding this comment.
nit: I'd name differently than id just to not get confused with other properties, etc. Something like defaultId might be more obvious
| @@ -134,6 +134,8 @@ const emit = defineEmits<{ | |||
|
|
|||
| const { stripRequiredLabel } = useUtilities() | |||
|
|
|||
| const fileInputId = attrs.id ? String(attrs.id) : useId() | |||
| @@ -175,8 +175,8 @@ const slots = useSlots() | |||
| const attrs = useAttrs() | |||
|
|
|||
| const isRequired = computed((): boolean => attrs?.required !== undefined && String(attrs?.required) !== 'false') | |||
| const inputId = attrs.id ? String(attrs.id) : useUniqueId() | |||
| const helpTextId = useUniqueId() | |||
| const inputId = attrs.id ? String(attrs.id) : useId() | |||
There was a problem hiding this comment.
You could make these computed, but the useId() call would need to be made outside of the computed function and then referenced, similar to this:
const defaultId = useId()
const inputId = computed((): string => attrs.id ? String(attrs.id) : defaultId)There was a problem hiding this comment.
Yes, I have an example in my first comment.
There was a problem hiding this comment.
Ah yep I missed that one 👍🏼
| @@ -100,7 +99,7 @@ const attrs = useAttrs() | |||
|
|
|||
| const switchInputElement = ref<HTMLInputElement | null>(null) | |||
|
|
|||
| const inputId = attrs.id ? String(attrs.id) : useUniqueId() | |||
| const inputId = attrs.id ? String(attrs.id) : useId() | |||
| @@ -495,8 +495,8 @@ const defaultKPopAttributes = { | |||
| const key = ref(0) | |||
| const stagingKey = ref(0) | |||
|
|
|||
| const multiselectWrapperId = attrs.id ? String(attrs.id) : useUniqueId() // unique id for the KLabel `for` attribute | |||
| const multiselectKey = useUniqueId() | |||
| const multiselectWrapperId = attrs.id ? String(attrs.id) : useId() // unique id for the KLabel `for` attribute | |||
| @@ -177,7 +176,7 @@ const props = defineProps({ | |||
| const slots = useSlots() | |||
| const attrs = useAttrs() | |||
|
|
|||
| const inputId = attrs.id ? String(attrs.id) : useUniqueId() | |||
| const inputId = attrs.id ? String(attrs.id) : useId() | |||
| @@ -363,6 +364,8 @@ const emit = defineEmits<{ | |||
| const attrs = useAttrs() | |||
| const slots = useSlots() | |||
|
|
|||
| const selectInputId = attrs.id ? String(attrs.id) : useId() | |||
| @@ -161,7 +160,7 @@ const value = computed({ | |||
| }, | |||
| }) | |||
|
|
|||
| const textAreaId = attrs.id ? String(attrs.id) : useUniqueId() | |||
| const textAreaId = attrs.id ? String(attrs.id) : useId() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses: https://konghq.atlassian.net/browse/KHCP-14269
Remove dependancy on
vue-bind-once. In all components, rely on VueuseIdinstead ofnanoidfor generating unique values for accessibility attributes.