Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ktruncate): stop click propagation [KHCP 10009] #1904

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

adamdehaven
Copy link
Member

Summary

Stop click propagation on the KTruncate expand/collapse buttons to prevent it bubbling up to a table row, etc.

@adamdehaven adamdehaven requested a review from a team as a code owner December 11, 2023 14:17
Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit 9e3a992
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/65771a020c6b6e000899facb
😎 Deploy Preview https://deploy-preview-1904--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 9e3a992
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/65771a028062ca0008aa4bd3
😎 Deploy Preview https://deploy-preview-1904--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did not functional test because no example in docs.

@adamdehaven adamdehaven merged commit 3bec03c into alpha Dec 11, 2023
9 checks passed
@adamdehaven adamdehaven deleted the fix/khcp-10009-ktruncate-capture-click branch December 11, 2023 14:33
kongponents-bot pushed a commit that referenced this pull request Dec 11, 2023
# [9.0.0-alpha.74](v9.0.0-alpha.73...v9.0.0-alpha.74) (2023-12-11)

### Bug Fixes

* **ktruncate:** stop click propagation [KHCP-10009] ([#1904](#1904)) ([3bec03c](3bec03c))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.74 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants