fix(kcopy): icon having left margin when format is hidden #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
added 3 commits
December 7, 2023 14:33
Fix an issue when using KCopy’s `props.format` being set to `'hidden'` that adds an unnecessary left margin to the icon even though no text is shown. Signed-off-by: Philipp Rudloff <[email protected]>
Signed-off-by: Philipp Rudloff <[email protected]>
Signed-off-by: Philipp Rudloff <[email protected]>
kleinfreund
force-pushed
the
fix/kcopy-having-left-margin-when-format-is-hidden
branch
from
8becf64 to
6cebded
Compare
adamdehaven
approved these changes
Dec 7, 2023
kleinfreund
deleted the
fix/kcopy-having-left-margin-when-format-is-hidden
branch
kongponents-bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
# [9.0.0-alpha.71](v9.0.0-alpha.70...v9.0.0-alpha.71) (2023-12-07) ### Bug Fixes * **kcopy:** icon having left margin when format is hidden ([#1897](#1897)) ([9597f9e](9597f9e))
|
🎉 This PR is included in version 9.0.0-alpha.71 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(kcopy): icon having left margin when format is hidden
Fix an issue when using KCopy’s
props.formatbeing set to'hidden'that adds an unnecessary left margin to the icon even though no text is shown.chore(kcopy): remove unused styles
fix(kcopy): rendering badgeLabel content when badgeLabel isn’t set
Signed-off-by: Philipp Rudloff [email protected]
Notes
props.badgeon account of.truncate-contentadding a right marging and.text-icon-wrapperadding a left margin. It seems like this gap is unintentionally big currently.gapon a container would be a more robust strategy to create space between elements:.copy-badge-text. I left this untouched as it’s not strictly speaking a visual bug..k-copy { &-badge-text { margin-right: var(--kui-space-40, $kui-space-40); } }a dead style? I think nothing is actually using it so I’m removing it in 466ba91.Screenshots
Note the difference in gap for format
hiddento the blue box.PR Checklist