Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kcard): component reskin [KHCP-8971] #1804

Merged
merged 22 commits into from
Dec 5, 2023
Merged

feat(kcard): component reskin [KHCP-8971] #1804

merged 22 commits into from
Dec 5, 2023

Conversation

portikM
Copy link
Member

@portikM portikM commented Oct 31, 2023 •
edited
Loading

Summary

Jira
Figma

KCard component reskin.

Links:

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Tests coverage: test coverage was added for new features and bug fixes
  • Docs: includes a technically accurate README

@portikM portikM self-assigned this Oct 31, 2023
@netlify Netlify
Copy link

netlify bot commented Oct 31, 2023 •
edited
Loading

✅ Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit b4c8a7b
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/656e2917110f50000714f400
😎 Deploy Preview https://deploy-preview-1804--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 31, 2023 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit b4c8a7b
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/656e2917bfc99100087f360d
😎 Deploy Preview https://deploy-preview-1804--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@portikM portikM force-pushed the feat/khcp-8971-kcard-reskin branch from 871c149 to 4dde509 Compare October 31, 2023 21:10
@portikM portikM marked this pull request as ready for review October 31, 2023 21:55
adamdehaven
adamdehaven requested changes Nov 1, 2023
View reviewed changes
docs/components/card.md Outdated Show resolved Hide resolved
docs/components/card.md Show resolved Hide resolved
docs/components/card.md Outdated Show resolved Hide resolved
docs/components/card.md Outdated Show resolved Hide resolved
docs/components/card.md Outdated Show resolved Hide resolved
src/components/KCard/KCard.vue Show resolved Hide resolved
src/components/KCard/KCard.vue Outdated Show resolved Hide resolved
src/components/KCard/KCard.vue Outdated Show resolved Hide resolved
src/components/KCard/KCard.vue Outdated Show resolved Hide resolved
src/components/KCard/KCard.vue Outdated Show resolved Hide resolved
@portikM portikM requested a review from adamdehaven November 1, 2023 15:19
adamdehaven
adamdehaven reviewed Nov 1, 2023
View reviewed changes
docs/guide/migrating-to-version-9.md Outdated Show resolved Hide resolved
src/components/KCard/KCard.cy.ts Outdated Show resolved Hide resolved
src/components/KCard/KCard.cy.ts Show resolved Hide resolved
src/components/KCard/KCard.vue Show resolved Hide resolved
src/components/KSlideout/KSlideout.vue Show resolved Hide resolved
src/components/KCard/KCard.vue Show resolved Hide resolved
@portikM portikM requested a review from adamdehaven November 1, 2023 16:30
@adamdehaven adamdehaven marked this pull request as draft November 1, 2023 21:53
@portikM portikM force-pushed the feat/khcp-8971-kcard-reskin branch from 6c1d236 to d956252 Compare November 6, 2023 17:12
@portikM portikM force-pushed the feat/khcp-8971-kcard-reskin branch from d956252 to 242648a Compare November 15, 2023 14:28
@portikM portikM force-pushed the feat/khcp-8971-kcard-reskin branch from 242648a to 142c60e Compare November 23, 2023 14:56
adamdehaven
adamdehaven reviewed Nov 30, 2023
View reviewed changes
docs/components/card.md Outdated Show resolved Hide resolved
docs/components/card.md Outdated Show resolved Hide resolved
docs/guide/migrating-to-version-9.md Outdated Show resolved Hide resolved
docs/guide/migrating-to-version-9.md Outdated Show resolved Hide resolved
sandbox/pages/SandboxCard.vue Outdated Show resolved Hide resolved
src/components/KSlideout/KSlideout.vue Show resolved Hide resolved
src/styles/mixins/_typography.scss Outdated Show resolved Hide resolved
@portikM portikM force-pushed the feat/khcp-8971-kcard-reskin branch from 142c60e to cd6f273 Compare November 30, 2023 16:19
@portikM portikM marked this pull request as ready for review November 30, 2023 16:38
@kleinfreund kleinfreund mentioned this pull request Dec 1, 2023
Merged
@portikM portikM force-pushed the feat/khcp-8971-kcard-reskin branch from 22677a5 to a257ce7 Compare December 1, 2023 14:28
@portikM portikM enabled auto-merge (squash) December 5, 2023 14:00
@portikM portikM disabled auto-merge December 5, 2023 14:00
adamdehaven
adamdehaven approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adamdehaven adamdehaven merged commit 0375d1d into alpha Dec 5, 2023
9 checks passed
@adamdehaven adamdehaven deleted the feat/khcp-8971-kcard-reskin branch December 5, 2023 14:07
kongponents-bot pushed a commit that referenced this pull request Dec 5, 2023
@semantic-release-bot
chore(release): 9.0.0-alpha.68 [skip ci]
ba7188d 
# [9.0.0-alpha.68](v9.0.0-alpha.67...v9.0.0-alpha.68) (2023-12-05)

### Bug Fixes

* disable percy from blocking CI ([445bf74](445bf74))
* release ([3eb055d](3eb055d))

### Features

* **kcard:** component reskin [KHCP-8971] ([#1804](#1804)) ([0375d1d](0375d1d))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0-alpha.68 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleinfreund kleinfreund kleinfreund left review comments

@adamdehaven adamdehaven adamdehaven approved these changes

@kongponents-bot kongponents-bot Awaiting requested review from kongponents-bot

@jillztom jillztom Awaiting requested review from jillztom

@kaiarrowood kaiarrowood Awaiting requested review from kaiarrowood

Assignees

@portikM portikM

Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@portikM @kongponents-bot @adamdehaven @kleinfreund