Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix linter issues and use deterministic golangci-lint version used both locally and in CI #464

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Aug 22, 2024

Use a deterministic version of golangci-lint that is the same locally and on CI.

@pmalek pmalek added area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. area/ci labels Aug 22, 2024
@pmalek pmalek self-assigned this Aug 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.85%. Comparing base (77f320b) to head (4fc6b25).

Files Patch % Lines
kong/custom_entity_service.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
+ Coverage   59.79%   59.85%   +0.05%     
==========================================
  Files          71       71              
  Lines        4455     4449       -6     
==========================================
- Hits         2664     2663       -1     
+ Misses       1172     1167       -5     
  Partials      619      619              
Flag Coverage Δ
2.1 36.27% <16.66%> (+0.02%) ⬆️
2.2 48.68% <16.66%> (+0.04%) ⬆️
2.3 49.31% <16.66%> (+0.04%) ⬆️
2.4 49.35% <16.66%> (+0.04%) ⬆️
2.5 49.35% <16.66%> (+0.04%) ⬆️
2.6 49.35% <16.66%> (+0.04%) ⬆️
2.7 51.04% <16.66%> (+0.04%) ⬆️
2.8 51.04% <16.66%> (+0.04%) ⬆️
3.0 55.18% <16.66%> (+0.05%) ⬆️
3.1 56.79% <16.66%> (+0.05%) ⬆️
3.2 56.79% <16.66%> (+0.05%) ⬆️
3.3 56.79% <16.66%> (+0.05%) ⬆️
3.4 59.15% <16.66%> (+0.05%) ⬆️
3.5 56.97% <16.66%> (+0.05%) ⬆️
3.6 56.97% <16.66%> (+0.05%) ⬆️
community 44.05% <16.66%> (+0.03%) ⬆️
enterprise 58.28% <16.66%> (+0.05%) ⬆️
integration 59.85% <16.66%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek marked this pull request as ready for review August 22, 2024 08:54
@pmalek pmalek requested review from a team as code owners August 22, 2024 08:54
@pmalek pmalek enabled auto-merge (squash) August 22, 2024 08:56
Copy link
Contributor

@randmonkey randmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One step before me 💯

@pmalek pmalek merged commit c64125c into main Aug 22, 2024
79 checks passed
@pmalek pmalek deleted the fix-linter branch August 22, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants