Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Service Catalog Datadog integration #8154

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cloudjumpercat
Copy link
Contributor

Description

Adding Datadog as a new Service Catalog integration.

DOCU-4109

Testing instructions

Preview link:

Checklist

@cloudjumpercat cloudjumpercat added the review:sme Request for SME review, external to the docs team. label Nov 20, 2024
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 1126c36
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/673e395fff46b500085779a4
😎 Deploy Preview https://deploy-preview-8154--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93 (🟢 up 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@miko-bautista
Copy link

LGTM, thanks Diana! I'll merge the PR when we are ready for the Public Beta launch. FYI that there are a few UI polishes we'd like to address before going for an Internal Release (https://kongstrong.slack.com/archives/C068AHKGSPQ/p1731956817244099) , and so Public Beta won't happen for at least a week. Regardless, this PR is good to go from my perspective.

@miko-bautista miko-bautista marked this pull request as ready for review November 21, 2024 04:21
@miko-bautista miko-bautista requested a review from a team as a code owner November 21, 2024 04:21
@miko-bautista
Copy link

Oh whoops, I accidentally clicked the "mark as ready for review" button. 😓

@cloudjumpercat cloudjumpercat marked this pull request as draft November 21, 2024 14:33
@cloudjumpercat
Copy link
Contributor Author

Oh whoops, I accidentally clicked the "mark as ready for review" button. 😓

@miko-bautista No worries! I converted it back to a draft

@cloudjumpercat
Copy link
Contributor Author

LGTM, thanks Diana! I'll merge the PR when we are ready for the Public Beta launch. FYI that there are a few UI polishes we'd like to address before going for an Internal Release (https://kongstrong.slack.com/archives/C068AHKGSPQ/p1731956817244099) , and so Public Beta won't happen for at least a week. Regardless, this PR is good to go from my perspective.

@miko-bautista Thanks for the review! I'd like to add a line after the integration instructions about selecting the region in Datadog (I think that's what happens here based on the brief) once I can test it in the internal release/beta. Do dashboards still need to be public for Konnect to ingest them?

@miko-bautista
Copy link

miko-bautista commented Nov 22, 2024

Do dashboards still need to be public for Konnect to ingest them?

@cloudjumpercat I believe Datadog Dashboards do not need to be public for Service Catalog to ingest them, but I asked Miles a question as a comment on this document just to be sure: https://docs.google.com/document/d/14fNT_KPVEtgtIMlrI180jDwsHD4BaF7u5j4cqurbPKI/edit?disco=AAABY-yC8fs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:sme Request for SME review, external to the docs team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants