-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inigo plugin initial docs #7785
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Can you please add "Inigo" to the dictionary file here: https://github.com/inigolabs/docs.konghq.com/blob/main/.github/styles/kong/dictionary.txt That'll prevent the name from being flagged as a spelling error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor phrasing and formatting adjustments
}, | ||
{ | ||
"config": { | ||
"fields": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the config fields are missing here. Could you please add them, then base the example file off the basic config that the plugin expects?
The example file would be at app/_hub/inigo/inigo/examples/_index.yml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our current plugin doesn't have any configuration, I wasn't sure how to represent that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. That's a good question. We haven't had that use case before, so I'm not sure that we've built in support for disabling the config key in the output (here: https://deploy-preview-7785--kongdocs.netlify.app/hub/inigo/inigo/configuration/). Let me look into that.
https://deploy-preview-7785--kongdocs.netlify.app/hub/inigo/inigo/ here's the deploy preview, it works now 😄 |
@lena-larionova : is there anything else that needs to be done from my end? |
@ejoffe nothing as of right now. We're waiting for the green light on our end. |
Description
This PR adds the docs for Inigo Kong Plugin
Testing instructions
Preview link:
Checklist