Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit CMake message about MoltenVK Vulkan compat #380

Merged
merged 1 commit into from
Jul 30, 2024
Merged

emit CMake message about MoltenVK Vulkan compat #380

merged 1 commit into from
Jul 30, 2024

Conversation

kwsp
Copy link
Contributor

@kwsp kwsp commented Jul 28, 2024

@axsaucedo
Copy link
Member

Thank you - DCO check requires signed commit, see: https://github.com/KomputeProject/kompute/pull/382/checks?check_run_id=28023370279

@kwsp kwsp force-pushed the molten-message branch from b034503 to ed43c72 Compare July 30, 2024 15:04
@kwsp
Copy link
Contributor Author

kwsp commented Jul 30, 2024

done

@axsaucedo
Copy link
Member

Thanks - but DCO still not passing

@kwsp
Copy link
Contributor Author

kwsp commented Jul 30, 2024

oh so you don't actually want the commit GPG signed, just a literall sign off message?

@axsaucedo
Copy link
Member

Yes correct, this is the github requirement with -s flag - I do use gpg signed commits but DCO requires the former

@kwsp kwsp force-pushed the molten-message branch from ed43c72 to 5260612 Compare July 30, 2024 15:22
@kwsp
Copy link
Contributor Author

kwsp commented Jul 30, 2024

done

axsaucedo
axsaucedo approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axsaucedo axsaucedo merged commit 40f9adf into KomputeProject:master Jul 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo axsaucedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwsp @axsaucedo