Issue #925: Added noncopy constructor for Tensor and TensorT #369
Conversation
|
Looks good - only thing would be to add a test, and we can then merge. You can add this on the Tensor test file. |
|
Just following up, do you think you would be able to have a look with a short test @ThePseudo ? |
|
Sorry for the delay, at some point stuff happened and I lost track of a few things (one being this). I created a short test, which could be expanded upon, but is basically "inspired" by the other test already present. I hope this works! |
|
No worries @ThePseudo, thank you for following up - running test suite |
|
@ThePseudo it seems tests failing, did you run locally? |
|
The terrible thing is that I am not really an expert in the Google test suite... but I found that the tests were failing for a good reason, apparently, and it is building. Which is strange, since "it worked on my machine", but let's try this out |
Added methods reserve() and constructor for Tensor and TensorT Signed-off-by: Andrea Calabrese <[email protected]>
Tensor now has a binding on the manager, allowing to be created from the manager itself rather than passing arguments to the Tensor class (similarly to the copy-tensor) Signed-off-by: Andrea Calabrese <[email protected]>
There was a problem hiding this comment.
Thank you @ThePseudo - remaining commment on a small docstring change required
Reserved tensor now has a proper test, allocating 3 uint32_t. Signed-off-by: Andrea Calabrese <[email protected]>
It should be done now, but tell me if the format is not correct (I took inspiration from previous docstrings) |
|
Added extra suggestion as it needs to follow the same format as rest of docstrings |
|
Thank you @ThePseudo - signed commit required, and we should be able to wrap it up :) |
As for the title. Suggestion provided by axsaucedo Co-authored-by: Alejandro Saucedo <[email protected]> Signed-off-by: Andrea Calabrese <[email protected]>
Forgot it, now added! :D |
|
Thanks! |
Added methods reserve() and constructor for Tensor and TensorT