Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example build #340

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

ToKiNoBug
Copy link
Contributor

@ToKiNoBug ToKiNoBug commented Nov 2, 2023

I see 2 example tests in "C++ Test" action failed after merging my PR.

It was caused by CMAKE_SOURCE_DIR in file cmake/set_package_info.cmake to access readme and license files. It seems ok beacuse they works almost the same as PROJECT_SOURCE_DIR, but in example builds CMAKE_SOURCE_DIR points to examples/logistic_regression , however license and readme files are not located here.

So I replaced CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR to fix this.

The cpp_example gh action is also changed.
Before this, cmd line parameter KOMPUTE_OPT_FROM_SOURCE=ON doesn't start with a -D prefix, so it will be ignored without any warnings and the value of KOMPUTE_OPT_FROM_SOURCE is still false.
As a result, example builds will still access kompute from the remote master branch instead of the parent directory. I have to fix this, otherwise gh actions will always fail.

Copy link
Member

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution

@axsaucedo axsaucedo merged commit 1d449da into KomputeProject:master Nov 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants