Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand privacy mode #2468

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Expand privacy mode #2468

merged 5 commits into from
Aug 22, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Aug 19, 2024 •
edited
Loading

Closes https://github.com/KomodoPlatform/komodo-wallet-desktop/issues/2466

To test:

  • Enter privacy mode, and check all screens and modals to confirm fiat / crypto values are redacted.
  • Orderbooks should and input fields/buttons for values (e.g. MAX button) should be disabled in privacy mode.
  • Exit privacy mode, and confirm everything looks like normal.

@ShantanuSharma9873
Copy link
Collaborator

Issue Fixed,

  • By default, all crypto details, transaction values, and balances are visible.
  • When Privacy mode is turned ON, all values are hidden, and none are displayed.
  • Confirmed that after disabling Privacy mode, all values and details are displayed again.

Attachment:
https://github.com/user-attachments/assets/7be8dac7-10bb-4708-b926-2481df2ba1bf

ShantanuSharma9873
ShantanuSharma9873 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@ShantanuSharma9873 ShantanuSharma9873 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue Fixed.

@smk762 smk762 merged commit 0c973f2 into dev-kdf Aug 22, 2024
6 checks passed
@smk762 smk762 deleted the fix/privacy-mode-history branch August 22, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShantanuSharma9873 ShantanuSharma9873 ShantanuSharma9873 approved these changes

@AndrewDelaney AndrewDelaney Awaiting requested review from AndrewDelaney

@cipig cipig Awaiting requested review from cipig

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smk762 @ShantanuSharma9873